NVIDIA / NVIDIA/IsaacTeleop

cloudxr: print the runtime/WSS banner from CloudXRLauncher, not each example

Open
#943 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
385
Forks
88
Avg merge
3d 23h
Merged PRs (30d)
82

Description

Every example that enters CloudXRLauncher.launch_context repeats the same two lines by hand:

print(f"[live] CloudXR runtime started (WSS log: {launcher.wss_log_path})")
print("[live] waiting for headset connection… (Ctrl+C to stop)")

They appear in the mcap_record_replay live and record scripts, deviceio_live_view, noitom, and teleop_ros2, so the wording drifts and a new example has to remember to add them. The launcher already knows the WSS log path and whether it started, attached to, or owns the runtime — it should print this itself.

Raised in review of #927 (https://github.com/NVIDIA/IsaacTeleop/pull/927#discussion_r3756875185).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CloudXRLauncher.launch_context, then compare the repeated banner in the mcap_record_replay live and record scripts, deviceio_live_view, noitom, and teleop_ros2 examples. Done means the launcher owns this output consistently and the examples no longer repeat it; verify the affected launch paths and wording.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.