NVIDIA-ISAAC-ROS / NVIDIA-ISAAC-ROS/isaac_ros_pose_estimation

Potential inconsistency between `nvdiffrast` and this project in `interpolate` method

Open
#74 0 comments 0 reactions 1 assignee View on GitHub

@yuanknv is already working on this.

Since May 20, 2025.

bug
Dominant language
C++
Stars
501
Forks
57
PR merge metrics
No merged PRs in 30d

Description

Hello! Thank you for your excellent work! We are currently migrating the FoundationPose algorithm to a non-ROS environment and noticed a potential inconsistency worth verifying.

In the original nvdiffrast library, the interpolate method determines p.instance_mode based on the ​shape dimensions of the input attr code reference. However, in the current migrated interpolate wrapper code reference, this check is implemented using the ​vector length of attr, which results in behavioral differences compared to the original implementation.

We observed this issue specifically during our implementation of the original algorithm's use_light rendering process, where it affects the interpolation of the diffuse_intensity_map. However, this discrepancy does not appear to impact the ​correctness of the current project’s outputs.

We would greatly appreciate your insights on this observation. If this is indeed an unintended discrepancy, we would be happy to submit a pull request to align the logic with the original behavior, pending your guidance.

Thank you for your time and consideration!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.