NVIDIA-ISAAC-ROS / NVIDIA-ISAAC-ROS/isaac_ros_common

`run-dev.sh` does not pass `RMW_IMPLEMENTATION` to docker container

Open
#156 2 comments 0 reactions 1 assignee View on GitHub

@hemalshahNV is already working on this.

Since Nov 8, 2024.

enhancement verify to close
Dominant language
C++
Stars
317
Forks
227
PR merge metrics
No merged PRs in 30d

Description

In run-dev.sh, we have
DOCKER_ARGS+=("-e ROS_DOMAIN_ID")
which is good. But it would be great to also have
DOCKER_ARGS+=("-e RMW_IMPLEMENTATION")
in case the host uses a non-default one (in my case, I have found that rmw_cyclonedds_cpp usually works better).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.