NVIDIA-ISAAC-ROS / NVIDIA-ISAAC-ROS/isaac_ros_common

run_dev.sh : git lfs print_error never prints

Open
#151 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
317
Forks
227
PR merge metrics
No merged PRs in 30d

Description

Due to the set -e usage at the top of the script, when the git lfs check is run:

# Check if git-lfs is installed.
git lfs &>/dev/null
if [[ $? -ne 0 ]] ; then
    print_error "git-lfs is not insalled. Please make sure git-lfs is installed before you clone the repo."
    exit 1
fi

The check is never called because the git lfs command fails and no output is seen. I know git lfs is a prerequisite but it took me a very long time to remember that when setting up a new machine, as I had expected the error to be printed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in run_dev.sh at the top-level set -e and the git lfs check shown in the issue. Run the script on a machine without git-lfs to confirm the current behavior, then verify that the missing prerequisite produces the intended print_error message instead of exiting silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, shell
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.