NVIDIA-ISAAC-ROS / NVIDIA-ISAAC-ROS/isaac_ros_common

run_dev.sh: using `--gpus` instead of `--runtime nvidia`

Open
#101 3 comments 0 reactions 1 assignee View on GitHub

@hemalshahNV is already working on this.

Since Nov 6, 2023.

coming soon! needs info
Dominant language
C++
Stars
317
Forks
227
No merged PRs in 30d

Description

https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_common/blob/6d3c5c00e0e2b3fc1d75eb4286848d23b05d6dca/scripts/run_dev.sh#L195-L203

I noticed run_dev.sh's Docker container works (torch.cuda.is_available() returns True) if I replace --runtime nvidia with --gpus all. I also noticed in the dev environment setup guide (https://nvidia-isaac-ros.github.io/getting_started/dev_env_setup.html) that nvidia-container-runtime is deprecated. Is using --gpus all more suitable on newer versions of Docker?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.