Subsume ESMF regrid logging configuration under log level
@sadielbartholomew arbeitet bereits daran.
Seit 22.2.2024.
- Vorherrschende Sprache
- Python
- Sterne
- 150
- Forks
- 23
- Ø Merge
- 1 T. 11 Std.
- Gemergte PRs (30 T.)
- 2
Beschreibung
The cf.regrid_logging flag can turn the logging from ESMF regridding on and off as required under cf, but I think it would be cleaner and more natural to the user if it such logging was controlled under the cf logging system.
More specifically I propose that ESMF logging is switched on when the cf.log_level is set to 'INFO' (2) or higher, otherwise off, and perhaps we can, consistently with other functions, provide a verbose keyword argument to the two regridding methods which can override the global log level if a user does want to force the ESMF logging to be enabled. Then we can remove this flag.
Happy to consider other thoughts on this, though, if anyone thinks the current set-up is preferable or there is a better alternative way to manage the configuration of the ESMF logging.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.