MetOffice / MetOffice/SimSys_Scripts

Update diff commands in UMDP3 fixer

未关闭
#208 1 条评论 0 个 reaction 已指派 1 人 已被 @Pierre-siddall 认领 在 GitHub 查看
bug
主要语言
Python
星标
9
派生
19
平均合并
5 天 48 分钟
30 天内合并 PR
4

描述

UMDP3 fixer currently uses fcm diff and bdiff commands to take the difference between the equivalent of the main branch and the developers branch for example in this statement:

```Python
def get_branch_diff():
"""If in a local working copy of an FCM branch, return a
list of files returned by running a branch-diff command"""

# Use the bdiff command to extract a list of files that have changed
# on the user's branch
bdiff = subprocess.Popen(
"fcm bdiff --summarize", stdout=subprocess.PIPE, shell=True
)

bdiff_stdout, _ = bdiff.communicate()
bdiff_stdout = bdiff_stdout.decode(sys.stdout.encoding)
```
Therefore UMDP3 fixer needs to be refactored to reflect the move to GitHub.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。