MetOffice / MetOffice/SimSys_Scripts

Update diff commands in UMDP3 fixer

Open
#208 1 comment 0 reactions 1 assignee Claimed by @Pierre-siddall View on GitHub
bug
Dominant language
Python
Stars
9
Forks
19
Avg merge
5d 48m
Merged PRs (30d)
4

Description

UMDP3 fixer currently uses fcm diff and bdiff commands to take the difference between the equivalent of the main branch and the developers branch for example in this statement:

```Python
def get_branch_diff():
"""If in a local working copy of an FCM branch, return a
list of files returned by running a branch-diff command"""

# Use the bdiff command to extract a list of files that have changed
# on the user's branch
bdiff = subprocess.Popen(
"fcm bdiff --summarize", stdout=subprocess.PIPE, shell=True
)

bdiff_stdout, _ = bdiff.communicate()
bdiff_stdout = bdiff_stdout.decode(sys.stdout.encoding)
```
Therefore UMDP3 fixer needs to be refactored to reflect the move to GitHub.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.