MaxGfeller / MaxGfeller/array-patch

Swapped items are not detected

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Ran immediately into this issue

var arrayPatch = require("array-patch")

var arr1 = [1, 2, 3, 4, 5]
var arr2 = [1, 3, 2, 4, 5]
 
var patch = arrayPatch.createPatch(arr1, arr2)
console.log(patch)

output: []

https://runkit.com/embed/uuflz6agfg2m

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the JavaScript reproduction from the issue and tracing the createPatch entry point to see why [1, 2, 3, 4, 5] and [1, 3, 2, 4, 5] produce an empty patch. Add regression coverage for this swapped-item case; done means the generated patch represents the changed order and applies correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.