MaterialDesignInXAML / MaterialDesignInXAML/MaterialDesignInXamlToolkit
Snackbar DeactivateStoryboardCompletedEvent Bug
未关闭
还没有人认领这个 Issue。
bug
evaluation required
- 主要语言
- C#
- 星标
- 16.3k
- 派生
- 3.5k
- 平均合并
- 1 天 22 小时
- 30 天内合并 PR
- 8
描述
I think this is a bug...
.../MaterialDesignThemes.Wpf/Snackbar.cs
public static readonly RoutedEvent DeactivateStoryboardCompletedEvent = EventManager.RegisterRoutedEvent(
nameof(DeactivateStoryboardCompleted), RoutingStrategy.Bubble, typeof(SnackbarMessageEventArgs), typeof(Snackbar));
public event RoutedPropertyChangedEventHandler<SnackbarMessage> DeactivateStoryboardCompleted
{
add => AddHandler(DeactivateStoryboardCompletedEvent, value);
remove => RemoveHandler(DeactivateStoryboardCompletedEvent, value);
}
private static void OnDeactivateStoryboardCompleted(IInputElement snackbar, SnackbarMessage message)
{
var args = new SnackbarMessageEventArgs(DeactivateStoryboardCompletedEvent, message);
snackbar.RaiseEvent(args);
}
Prompt type mismatch when I register events...
I didn't look at all the code. Maybe it's right?
public static readonly RoutedEvent DeactivateStoryboardCompletedEvent = EventManager.RegisterRoutedEvent(
nameof(DeactivateStoryboardCompleted), RoutingStrategy.Bubble, typeof(RoutedPropertyChangedEventHandler<SnackbarMessageEventArgs>), typeof(Snackbar));
public event RoutedPropertyChangedEventHandler<SnackbarMessageEventArgs> DeactivateStoryboardCompleted
{
add => AddHandler(DeactivateStoryboardCompletedEvent, value);
remove => RemoveHandler(DeactivateStoryboardCompletedEvent, value);
}
private static void OnDeactivateStoryboardCompleted(IInputElement snackbar, SnackbarMessage message)
{
var snackbarMessageEventArgs = new SnackbarMessageEventArgs(DeactivateStoryboardCompletedEvent, snackbar, message);
var args = new RoutedPropertyChangedEventArgs<SnackbarMessageEventArgs>(snackbarMessageEventArgs, snackbarMessageEventArgs, DeactivateStoryboardCompletedEvent);
snackbar.RaiseEvent(args);
}
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 MaterialDesignThemes.Wpf/Snackbar.cs 开始,同时检查 DeactivateStoryboardCompleted 事件注册、委托声明和 OnDeactivateStoryboardCompleted 调用。检查涉及的 WPF 路由事件类型,并构建项目以确认报告的类型不匹配问题已解决,且没有引入其他事件签名错误。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- csharp
- 领域
- desktop
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100