MaterialDesignInXAML / MaterialDesignInXAML/MaterialDesignInXamlToolkit

Shadows and appearances improvements

Ouverte
#2,377 1 commentaire 2 réactions 1 personne assignée Voir sur GitHub

@Keboo y travaille déjà.

Depuis le 16/7/2021.

enhancement up-for-grabs
Langage dominant
C#
Étoiles
16.3k
Forks
3.5k
Merge moyen
1 j 22 h
PR mergées (30 j)
8

Description

Hello to all!
I want to suggest some performance improvements for animations for MaterialDesignInXamlToolkit library and resolve some issues, I faced with.

So, the first one: don't use BitmapCache for Shadows and for animations. I suggest to use FastShadow (https://stackoverflow.com/questions/961875/wpf-animation-ui-features-performance-and-benchmarking) with the same appearance. Why don't use BitmapCache (and related ShadowAssist with default set for CacheMode)? BitmapCache invokes some problems on WPF, for example when user has multiple windows. And if those shadows are not static (for example when animate them in DrawerHost or other controls) I explained it in #2260 and https://stackoverflow.com/questions/66471514/wpf-rendering-issue-on-any-machine-related-to-bitmapcache. But if you want to test on your machine, please test this repo - https://github.com/Erapchu/GhostWindows
And please, just use one ShadowAssist instance instead of directly BitmapCache when coding in XAML.
Additionally, may be resolve issue with graphic artifacts? I remember one artifact related to #2125 issue.

This is just suggestions, and if maintainers don't want to rewrite some code, I'll understand it. Because it's may be hard work to rewrite controls and handle all of situations.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.