MagicStack / MagicStack/uvloop
sys.exit(...) exception swallowed by uvloop
还没有人认领这个 Issue。
- 主要语言
- Cython
- 星标
- 11.9k
- 派生
- 616
- PR 合并指标
- 30 天内没有已合并 PR
描述
-
uvloop version:
0.19.0 -
Python version:
3.11.9 -
Platform:
MacOS 14.5 (Sonoma)
mamba 1.5.8
conda 24.5.0 -
Can you reproduce the bug with
PYTHONASYNCIODEBUGin env?:
Not yet -
Does uvloop behave differently from vanilla asyncio? How?:
I have never had this bug with vanilla asyncio
If a sys.exit(...) call is made while uvloop is being used in coroutines (in my case, through aiohttp crawling of web URLs), uvloop may catch the SystemExit exception, and not let it bubble as a SystemExit to the top of the application. Instead, it logs this at the ERROR level:
2024-07-26 06:25:06,802 ERROR asyncio Fatal error on transport TCPTransport
protocol: <uvloop.loop.SSLProtocol object at 0x16b54de80>
transport: <TCPTransport closed=False reading=False 0x1693bfff0>
Traceback (most recent call last):
File "uvloop/handles/stream.pyx", line 1007, in uvloop.loop.__uv_stream_buffered_on_read
File "uvloop/loop.pyx", line 109, in uvloop.loop.run_in_context1
File "uvloop/sslproto.pyx", line 382, in uvloop.loop.SSLProtocol.buffer_updated
File "uvloop/sslproto.pyx", line 711, in uvloop.loop.SSLProtocol._do_read
File "uvloop/sslproto.pyx", line 776, in uvloop.loop.SSLProtocol._do_read__copied
File "/opt/homebrew/Caskroom/miniforge/base/envs/work/lib/python3.11/ssl.py", line 912, in read
def read(self, len=1024, buffer=None):
File "/Users/dmoklaf/Local/metax/python_libraries/application.py", line 171, in _exit
sys.exit(code)
SystemExit: 1
Indeed, a quick look at the uvloop code shows that it logs the SystemExit exception, as SystemExit does not subclass OSError:
https://github.com/MagicStack/uvloop/blob/6c770dc3fbdd281d15c2ad46588c139696f9269c/uvloop/handles/basetransport.pyx#L40
PS: there also seems to be other _fatal_error implementations in uvloop, I am not completely sure if these other places do not suffer from the same issue
And it also swallows the SystemExit exception, instead of propagating it upward as requested by the Python specification.
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 uvloop/handles/basetransport.pyx 中链接的 _fatal_error 实现附近开始,在 uvloop 下复现所报告的 SystemExit 行为。检查 issue 中提到的其他 _fatal_error 实现,然后验证 SystemExit 会传播到应用程序,而不是被记录日志后吞掉。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- networking
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 38/100