MagicStack / MagicStack/httptools

TestResponseParser.test_parser_response_leninent_headers_1 test failure

Open
#119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.3k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

Hello,

Builing httptools 0.6.4, I see:

```
=================================== FAILURES ===================================
__________ TestResponseParser.test_parser_response_leninent_headers_1 __________
Traceback (most recent call last):
File "/gnu/store/jjcka1g6sk2cvwx8nm4fdwpdq3vll0v0-python-3.10.7/lib/python3.10/unittest/case.py", line 59, in testPartExecutor
yield
File "/gnu/store/jjcka1g6sk2cvwx8nm4fdwpdq3vll0v0-python-3.10.7/lib/python3.10/unittest/case.py", line 591, in run
self._callTestMethod(testMethod)
File "/gnu/store/jjcka1g6sk2cvwx8nm4fdwpdq3vll0v0-python-3.10.7/lib/python3.10/unittest/case.py", line 549, in _callTestMethod
method()
File "/tmp/guix-build-python-httptools-0.6.4.drv-0/source/tests/test_parser.py", line 132, in test_parser_response_leninent_headers_1
with self.assertRaisesRegex(
File "/gnu/store/jjcka1g6sk2cvwx8nm4fdwpdq3vll0v0-python-3.10.7/lib/python3.10/unittest/case.py", line 226, in __exit__
self._raiseFailure("{} not raised".format(exc_name))
File "/gnu/store/jjcka1g6sk2cvwx8nm4fdwpdq3vll0v0-python-3.10.7/lib/python3.10/unittest/case.py", line 163, in _raiseFailure
raise self.test_case.failureException(msg)
AssertionError: HttpParserError not raised
=========================== short test summary info ============================
FAILED tests/test_parser.py::TestResponseParser::test_parser_response_leninent_headers_1 - AssertionError: HttpParserError not raised
========================= 1 failed, 39 passed in 0.08s =========================
```

This happens using the systemt-provided llhttp and http-parser libraries. Python is at 3.10.7, while the direct inputs are:
```
dependencies: http-parser@2.9.4-1.ec8b5ee llhttp@9.1.3 python-cython@0.29.32 python-pytest@8.3.3
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tests/test_parser.py and run TestResponseParser.test_parser_response_leninent_headers_1 using the reported Python, http-parser, and llhttp versions. Trace why HttpParserError is not raised with the system-provided libraries; done means the test behavior is resolved or the compatibility expectation is made explicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.