MagicStack / MagicStack/asyncpg
set_type_codec() doesn't work with copy_records_to_table()
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 8.1k
- 派生
- 468
- PR 合并指标
- 30 天内没有已合并 PR
描述
- asyncpg version: 0.23.0
- PostgreSQL version: 9.5.21
- Do you use a PostgreSQL SaaS? If so, which? Can you reproduce
the issue with a local PostgreSQL install?: No and this is on a local PSQL install. - Python version: 3.6.13
- Platform: Ubuntu 16.04.6 LTS
- Do you use pgbouncer?: No
- Did you install asyncpg with pip?: Yes
- If you built asyncpg locally, which version of Cython did you use?: n/a
- Can the issue be reproduced under both asyncio and
uvloop?: Not tried
The following:
await conn.set_type_codec(
"numeric",
encoder=str,
decoder=float,
schema="pg_catalog",
)
Doesn't work when used with copy_records_to_table()
...
File "asyncpg/protocol/protocol.pyx", line 504, in copy_in
File "asyncpg/protocol/protocol.pyx", line 437, in asyncpg.protocol.protocol.BaseProtocol.copy_in
asyncpg.exceptions._base.InternalClientError: no binary format encoder for type numeric (OID 1700)
This is despite solving issue https://github.com/MagicStack/asyncpg/issues/157 which added a binary format codec for numeric types - https://github.com/MagicStack/asyncpg/commit/0f8483517ebde66f3c7cc858fa6ad227c6e3fd64
Can we get the ability to provide a custom decoder without having to also provide an encoder then internally just fall back to the default encoder? I believe it should solve the issue. E.g.
await conn.set_type_codec(
"numeric",
decoder=float,
schema="pg_catalog",
)
or
await conn.set_type_codec(
"numeric",
encoder=None,
decoder=float,
schema="pg_catalog",
)
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
使用 issue 中的数值示例,通过 set_type_codec() 和 copy_records_to_table() 重现该失败。先从 asyncpg/protocol/protocol.pyx 中的 copy_in 和 BaseProtocol.copy_in 开始,然后跟踪自定义 codec 的选择过程。当可以使用自定义解码器,同时 copy_records_to_table() 仍能获取 numeric 的编码器时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- postgresql, python
- 领域
- databases
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100