MagicStack / MagicStack/asyncpg
asyncpg does not work with "sslmode" query param when called from SQLAlchemy
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 8.1k
- 派生
- 468
- PR 合并指标
- 30 天内没有已合并 PR
描述
* **asyncpg version**: 0.22
* **PostgreSQL version**: 12.3
* **Do you use a PostgreSQL SaaS? If so, which? Can you reproduce
the issue with a local PostgreSQL install?**: I use DigitalOcean and was able to also reproduce it locally
* **Python version**: 3.8.9
* **Platform**: Linux
* **Do you use pgbouncer?**: No
* **Did you install asyncpg with pip?**: Yes
* **If you built asyncpg locally, which version of Cython did you use?**: -
* **Can the issue be reproduced under both asyncio and
[uvloop](https://github.com/magicstack/uvloop)?**: N/D
First, congratulation to the people of MagicStack for this great library.
When using DigitalOcean default environment DATABASE URL to set the database string on my app I got the following error:
```
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/pool/base.py", line 599, in __connect
connection = pool._invoke_creator(self)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/create.py", line 578, in connect
return dialect.connect(*cargs, **cparams)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/engine/default.py", line 558, in connect
return self.dbapi.connect(*cargs, **cparams)
File "/usr/local/lib/python3.8/site-packages/sqlalchemy/dialects/postgresql/asyncpg.py", line 747, in connect
await_only(self.asyncpg.connect(*arg, **kw)),
TypeError: connect() got an unexpected keyword argument 'sslmode'
```
In my app, since I use `psycopg2` to do some "management tasks", I also need to do something like that:
```
if ssl_enabled and driver == "asyncpg":
base_url += "?ssl=require"
elif ssl_enabled and driver == "psycopg2":
base_url += "?sslmode=require"
```
Shouldn't `asyncpg` use the more standard `sslmode=` query param instead of the `ssl=`?
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从回溯中显示的 SQLAlchemy PostgreSQL asyncpg 方言路径开始,尤其是 sqlalchemy/dialects/postgresql/asyncpg.py,并跟踪 URL 查询参数如何传递到 asyncpg.connect。使用 sslmode=require 重现失败,并将其与 ssl=require 进行比较。当预期的参数能够通过 SQLAlchemy 正常工作且不再出现 unexpected-keyword 错误,并且为连接 URL 情况提供 coverage 时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- postgresql, python, sqlalchemy
- 领域
- backend, databases
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100