LuaLS / LuaLS/vscode-lua

"Lua PSI Viewer" feature not working.

Open
#172 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
215
Forks
62
PR merge metrics
No merged PRs in 30d

Description

### Which OS are you using?

Linux

### Expected Behaviour

The "Lua PSI Viewer" feature, when ran, it expects some `index.html` file to be at this path:
~/.vscode/extensions/sumneko.lua-3.15.0-linux-x64/**client/web/dist/index.html**
but presumably the `index.html` file path actually exists here
~/.vscode/extensions/sumneko.lua-3.15.0-linux-x64/**client/webvue/build/index.html**

The error happens because of exactly this line:
https://github.com/LuaLS/vscode-lua/blob/9e91c07ce7b3b9fa162763b0eb7d39cf90033798/client/src/psi/psiViewer.ts#L18

so just do:
```diff
- private static readonly distDirectory = "client/web/dist";
+ private static readonly distDirectory = "client/webvue/build";
```

### Reproduction steps

Steps to reproduce:


Type: Lua PSI Viewer

Image

get this error message:

Image

### Additional Notes

the bug got introduces in ~3 years ago, by commit `1c7a326`

i actually dont know what this "Lua PSI Viewer" feature is for :P
Im curious to find out when it works (again)

Also, I was considering making this a pull request, but i dont know how to compile/run this project, so i cant test fix sry ):

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect client/src/psi/psiViewer.ts, especially the distDirectory value and how the PSI Viewer resolves index.html. Reproduce the Lua PSI Viewer command from the Command Palette and verify the packaged client/webvue/build/index.html path is used. Done means the viewer opens without the missing-file error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.