LuaLS / LuaLS/vscode-lua

setConfig api option to set only in memory

Open
#170 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
215
Forks
62
PR merge metrics
No merged PRs in 30d

Description

My extension dynamically generates a library bundle and sets a path in `userThirdParty` and `checkThirdParty: "ApplyInMemory"`, to allow the rest of my settings to be applied from the config.json, and library and plugin loaded, with minimal impact on the user's workspace. I currently set these two in the workspace via vscode settings apis, which leads to them being written to settings.json. Persisting these is undesirable as the `userThirdParty` path is a per-workspace path, which many users have complained about.

I noticed that the extension now provides a setConfig api, and was hoping to use this to provide those settings only in memory, but it seems they are also written back out to settings.json when set this way.

Would it be possible to have an "ApplyInMemory" option on the setConfig api for this case?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the setConfig API and the VS Code settings API to find where configuration changes are persisted. Done means an ApplyInMemory option applies userThirdParty and checkThirdParty without writing them to settings.json; the issue names no files or tests, so the relevant implementation and verification paths must be identified first.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.