LuaLS / LuaLS/vscode-lua

Addon manager plugin support

未关闭
#112 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

addon manager enhancement
主要语言
TypeScript
星标
215
派生
62
PR 合并指标
30 天内没有已合并 PR

描述

Explain the feature

The Lua Language Server supports plugins that allow users to write custom Lua scripts that the language server will then run to output a modified file. As of right now, the addon manager will download the plugin.lua file, but it will not tell the server to use it. There should be some easy (and safe) way for users to enable a plugin that they have installed.

Are there any potential drawbacks from adding the feature?

There are some serious security concerns with downloading a script off the internet and running it automatically on the user's computer. While the addons being installed should be reviewed and trusted before being merged into LLS-addons, there is always the chance of something slipping through.

We could ask the user to review the code themselves before approving the request to enable it - but at the end of the day, the safest option will always be to not run code created by other users.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先跟踪 addon manager 对下载的 plugin.lua 文件的处理方式,并查阅 LuaLS 关于 runtime.plugin 设置的文档。明确启用已安装插件所需的批准和安全要求,然后定义如何在不自动运行未经审查的代码的情况下验证完成情况。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua, typescript, vscode
领域
security, tooling
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。