LuaLS / LuaLS/vscode-lua

Addon manager plugin support

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

addon manager enhancement
Dominant language
TypeScript
Stars
215
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Explain the feature

The Lua Language Server supports plugins that allow users to write custom Lua scripts that the language server will then run to output a modified file. As of right now, the addon manager will download the plugin.lua file, but it will not tell the server to use it. There should be some easy (and safe) way for users to enable a plugin that they have installed.

Are there any potential drawbacks from adding the feature?

There are some serious security concerns with downloading a script off the internet and running it automatically on the user's computer. While the addons being installed should be reviewed and trusted before being merged into LLS-addons, there is always the chance of something slipping through.

We could ask the user to review the code themselves before approving the request to enable it - but at the end of the day, the safest option will always be to not run code created by other users.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the addon manager's handling of the downloaded plugin.lua file and review LuaLS's runtime.plugin setting documentation. Clarify the approval and safety requirements for enabling an installed plugin, then define how completion will be verified without automatically running unreviewed code.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, typescript, vscode
Domain
security, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.