LuaLS / LuaLS/lua-language-server

[Build] Windows ARM64 build failure: undefined symbol __longjmp_wrapper in fast_setjmp_arm64.s

Abierto
#3,337 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Lua
Estrellas
4.4k
Forks
442
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Description:
When attempting to compile lua-language-server on Windows on Arm using the MSVC toolchain (armasm64), the build fails during the assembly phase of the bee.lua dependency.

The assembler throws an error because the file 3rd/bee.lua/3rd/lua-patch/fast_setjmp_arm64.s attempts to export a symbol that is never defined in the text area, while also failing to export fast_longjmp.

Environment:
OS: Windows 11 (Arm64)
Compiler: MSVC (Host: ARM64, Target: ARM64)
Tool: armasm64.exe

Error Logs:
[1/125] Compile ASM build/obj/source_lua/fast_setjmp_arm64.obj
FAILED: build/obj/source_lua/fast_setjmp_arm64.obj
armasm64 -nologo -o build/obj/source_lua/fast_setjmp_arm64.obj 3rd/bee.lua/3rd/lua-patch/fast_setjmp_arm64.s
C:\Code\Tools\lua-language-server\3rd\bee.lua\3rd\lua-patch\fast_setjmp_arm64.s(40) : error A2023: undefined symbol: __longjmp_wrapper
END
[6/125] Compile C build/obj/source_lua/onelua.obj
C:\Code\Tools\lua-language-server\3rd\bee.lua\3rd\lua55\ldo.c(131): warning C4013: 'fast_longjmp' undefined; assuming extern returning int
C:\Code\Tools\lua-language-server\3rd\bee.lua\3rd\lua55\ldo.c(169): warning C4013: 'fast_setjmp' undefined; assuming extern returning int
[14/125] Compile C++ build/obj/source_bee/error.obj
ninja: build stopped: subcommand failed.

Proposed Workaround / Fix:
I was able to successfully generate the executable by modifying fast_setjmp_arm64.s as follows:

  1. Removing the EXPORT __longjmp_wrapper line (as it has no corresponding label).
  2. Adding EXPORT fast_longjmp to ensure the symbol is visible to the C code in ldo.c

Modified Assembly Header:

    EXPORT fast_setjmp
    EXPORT fast_longjmp  ; Added this
    ; EXPORT __longjmp_wrapper ; Removed this as it caused error A2023: undefined symbol: __longjmp_wrapper

Questions/Concerns:
While this allows the build to complete and the server to run, I am not 100% sure if:

  1. __longjmp_wrapper was intended to be an alias for fast_longjmp for compatibility with specific Windows exception handling.
  2. There is a specific reason fast_longjmp was omitted from the exports in the original ARM64 patch.

Could the maintainers verify if this is the correct way to align the ARM64 assembly with the Windows MSVC requirements?

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Inspecciona 3rd/bee.lua/3rd/lua-patch/fast_setjmp_arm64.s junto con 3rd/bee.lua/3rd/lua55/ldo.c, centrándote en los símbolos exportados y sus referencias de Windows ARM64. Ejecuta la compilación de MSVC armasm64 y verifica después que la fase de ensamblado se complete y que el ejecutable resultante se enlace y se ejecute sin cambiar el comportamiento esperado de fast_setjmp o fast_longjmp.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
c, lua
Área
build-system, operating-systems
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.