LuaLS / LuaLS/lua-language-server
Consider giving priority to added paths over gitignore files
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 442
- PR merge metrics
- No merged PRs in 30d
Description
Hello.
I was trying to make the VSCod extension detect my hammerspoon definitions, and it was not working.
Then I noticed the "Lua.workspace.useGitIgnore": false setting, and after setting it to false it started working.
I have this in my third party config
"Lua.workspace.userThirdParty": [
"/private/etc/nix-darwin/dotfiles/hammerspoon/Spoons/EmmyLua.spoon/annotations/"
]
That annotations folder is gitignored, but I seriously think it should take priority over the gitignore setting, because I manually added it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the Lua.workspace.userThirdParty and Lua.workspace.useGitIgnore settings are handled when workspace paths are filtered. Check the behavior for the supplied annotations path, which is gitignored but explicitly configured. Done means an explicitly added path is considered despite the gitignore setting, with the existing behavior preserved for other paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- developer-experience, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100