LuaLS / LuaLS/lua-language-server

non-`file:` URIs in library/userThirdParty settings don't work

Open
#3,064 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

my extension generates a LuaLS userThirdParty bundle dynamically from Factorio's doc files (from the local game install, generally). I'm working on trying to switch to using a virtual FS provider for these files instead of cluttering up real workspace-associated folders with them. I've registered as the provider for fmtk: uris, and i can open all the files for the generated bundle in vscode in editor tabs, but LuaLS won't load them as libraries.

I set

"Lua.workspace.userThirdParty": [
        "fmtk:/luals"
    ],

in my settings.json, instead of setting the generated folder path as i had done previously, but LuaLS seems to have completely ignored it.

I also tried

    "Lua.workspace.library": [
        "fmtk:/luals/factorio/library"
    ],

but that also seems to ignore anything that isn't a plain file path.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the fmtk: virtual file-system provider and the Lua.workspace.userThirdParty and Lua.workspace.library settings shown in the report. Trace how these settings resolve library paths; done means non-file URIs are loaded as libraries rather than ignored, with a regression test covering the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.