LuaLS / LuaLS/lua-language-server
Generics in nested functions don't work for some annotations unless there are no arguments passed
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 4.4k
- Forks
- 442
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
### How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
### Which OS are you using?
Windows
### What is the issue affecting?
Annotations
### Expected Behaviour
passing an argument should have no effect, and the types of nested functions should be resolved correctly
some examples:
```lua
---@generic T
---@param arg T
---@return fun(): fun(): T
local function POOL1(arg) return function() return function() return arg end end end -- implementing the function makes no difference for the typing
local func1 = POOL1(5.2) -- type is `fun(): fun(): number`
local func2 = func1(4) -- type should be `fun(): number`, instead it's `fun(): ` with an unresolved generic
```
```lua
---@class POOL2: { EnumerateActive: fun():(T, fun():T)) }
---@type POOL2
local headerPool = {}
local number, func = headerPool:EnumerateActive()
-- number type is `number`
-- func type should be `fun(): number`, instead it's `fun(): ` with an unresolved generic
```
```lua
---@alias POOL3 fun(arg: number): T, (fun():T)
---@type POOL3
local getPool
local number, func = getPool(3)
-- number type is `number`
-- func type should be `fun(): number`, instead it's `fun(): ` with an unresolved generic
```
all 3 examples work fine if you don't pass any argument
### Actual Behaviour
when an argument is passed to the outer function, the inner function doesn't have the generic resolved

if no arguments are passed (i.e. `headerPool.EnumerateActive()`), then they _are_ resolved properly
the type of the argument makes no difference, and annotating the function as accepting an argument also makes no difference
interestingly, when hovering over the function itself, the tooltip does show the correctly resolved types

### Reproduction steps
copy the provided snippets, and check which types the variables resolve to
### Additional Notes
Tested on both VSCode and Jetbrains IDEs
The example is contrived, my real usecase is to annotate an object pool class, that allows you to acquire objects of a given (generic) type, and allows iterating over them.
I know this has worked in a past version, though I don't remember how long ago that was (several weeks or months most likely)
### Log File
_No response_
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par reproduire les trois exemples d’annotations Lua fournis et examinez comment les types génériques imbriqués sont résolus lorsque la fonction externe reçoit un argument. Comparez les types inférés avec les cas sans argument et les résultats de hover attendus. La tâche est terminée lorsque les trois exemples résolvent leurs fonctions internes vers le type concret, tel que number, tout en conservant le comportement correct existant.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- devtools
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Clairement spécifiée
- Accessibilité débutants
- 48/100