LuaLS / LuaLS/lua-language-server
Please add an option under the 'hint' category to specify a max length for hints
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 4.4k
- Forks
- 442
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
How are you using the lua-language-server?
NeoVim
Which OS are you using?
Windows WSL
What is the issue affecting?
Other
Expected Behaviour
Ideally if the hint is over a certain length it would be trimmed to fit within that length.
Actual Behaviour
Currently there does appear to be some trimming of the hint if it is exceedingly long but it appears that it is very generous with what 'too long' is. In my case I would want it to be far more conservative, but I understand not everyone would have the same preference so a config value would be nice. I'll insert some examples below.
Reproduction steps
First make a really long type (a lot of '@cast' annotations will get you there quickly). Then enable inlay hints and watch as whole lines get filled with the inlay hint.
Additional Notes
Here is an excerpt from my Neovim configuration to demonstrate who bad it can get, I've wrapped the hints in comments to make reading easier:
for _, path --[[ : string ]] in ipairs(--[[ t: ]] vim.api.nvim_list_runtime_paths()) do
local lua_path --[[ : string]] = vim.fs.joinpath(path, "/lua")
local response --[[ : { gen: integer, flags: integer, atime: { nsec: integer, sec: integer }, ctime: { nsec: integer, sec: integer }, birthtime: { nsec: integer, sec: integer }, uid: integer,
gid: integ...(too long)...eger }|nil ]], _, _ = vim.uv.fs_stat(--[[ path: ]] lua_path)
if (response or {}).type == "directory" then
table.insert(paths, lua_path)
end
end
As you can see, the verbosity of the type for response makes the hint basically useless. There doesn't appear to be any faculty for controlling hint length in the lsp client capabilities or Neovim's lsp client so I'm hoping to be able to configure the server to just not send such long inlay hints in the first place.
I got carried away thinking about how limited hints could be displayed. Feel free to ignore everything past this point.
As for what to send instead, in my opinion I see three options:
- Nothing at all. If the type is too long just don't send the hint at all. This could be confusing to some but I believe it's better then filling your line with useless information.
- Hard trim the hint. In the case of the
responsehint, something like this: { gen: integer, flags: integer, atime: { nsec: integer, sec: integer }, ... } | nil. However this could be complex if it isn't simple to calculate a point to cut. - Simplify nested types. Using the response hint as an example again:
: { gen: integer, flags: integer, atime: table, ctime: table, birthtime: table, uid: integer } | nil. This could be combined with 2 to handle very large flat types (a table literal with dozens of keys).
If possible it would prioritise the type information for the top most values, then prioritise the types in the order their defined. The chances of a developer wanting to know the type of a table nested three layers deep is going to rare in comparison to a developer wanting to know the type of the second value in a table.
Ideally that would mean:
- Abbreviating the deepest table literal with
{key: value, ...}and potentially shortening it to justtableif the key/value is particularly long. - Starting at the deepest depth, abbreviate types in reverse definition order.
- If no more types can be abbreviated at the current depth, go up a level and try again.
Ultimately your not guaranteed to be able to shorten any arbitrary type like this, but it would go a long way for long literal types. Only a subset of literals would need to support abbreviation, these are them (in my opinion):
- Table abbreviations would look like:
{ key: value, ... } - Union abbreviations would look like
type | type | ... - Tuple abbreviations would look like
[type, type, ...]
Log File
No response
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Aucun fichier ni test n’est nommé dans l’issue. Commencez par localiser la configuration hint et le code qui formate et envoie les inlay hints, puis reproduisez le long exemple @cast dans Neovim. Le travail est terminé lorsqu’une longueur maximale configurable sous hint limite les hints trop longs sans affecter les plus courts, et que le comportement de troncature choisi est vérifié.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua, neovim
- Domaine
- developer-experience, tooling
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 30/100