LuaLS / LuaLS/lua-language-server

"Save as" can cause "duplicate defined alias"

未关闭
#2,745 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Lua
星标
4.4k
派生
442
PR 合并指标
30 天内没有已合并 PR

描述

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Annotations

Expected Behaviour

"Save as" should clear the cached aliases from the previous file (in the case of no workspace/folder)

Actual Behaviour

With a new window with no workspace, when I used "save as" I noticed the aliases from the file were still being used, causing a conflict duplicate defined alias with the newly named file. See repro steps.

image

Reproduction steps
  1. Start with a new window, no workspace, etc
  2. Create a new file, e.g., "test.lua"
  3. Add some code and save the file ( --@alias id integer\n )
  4. "Save as" test_2.lua
  5. (Optional) You may need to repeatedly "Save as" (e.g., test_3.lua) to trigger the bug, I couldn't 100% repro
  6. Observe Duplicate defined alias id

Reload editor to clear error

Additional Notes

This is an edge case, as typically you'd have an workspace or folder open (in which case 'save as' should keep the previous file cached also).

Log File

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

未指定源文件或测试。首先,在新窗口且不打开工作区的情况下,于 Visual Studio Code 扩展中重现该问题,然后跟踪 Save as 的处理以及缓存的注释别名。完成的标准是,重复执行 Save as 操作不再报告重复的已定义别名,同时保留所述的工作区行为。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua, vscode
领域
tooling
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。