LuaLS / LuaLS/lua-language-server

Function with generic variable return type loses typing after first return

Open
#2,599 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Linux

What is the issue affecting?

Type Checking

Expected Behaviour

ret2 in the example should be listed as string

Actual Behaviour

ret2 is listed as unknown

Reproduction steps
---@generic T
---@param arg T
---@return T ...
function GenericReturn(arg) end

local ret1, ret2 = GenericReturn("")
Additional Notes

Changing the return type to T|string correctly types the variable return but does not inherit the generic's typing.

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Begin by reproducing the generic return and vararg example in the issue, then trace the Lua language server's generic return-type inference and type-checking tests. Done means ret2 is inferred as string without changing the annotation, with a regression test covering the example.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.