LuaLS / LuaLS/lua-language-server
Possible typo when handling `workspace.library`
Open
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 442
- PR merge metrics
- No merged PRs in 30d
Description
[Here](https://github.com/LuaLS/lua-language-server/blob/e930179bbd6b3eb26721a676303e0e27cdb29290/script/workspace/workspace.lua#L181) we handle `Lua.workspace.library`, but unlike the other paths, we index `debug` (the global) and add to it, instead of `pattern`.
This looks like it is almost definitely a typo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in script/workspace/workspace.lua around line 181 and compare the workspace.library handling with the other paths nearby. Verify whether pattern should be indexed instead of debug, then confirm that workspace.library handling behaves consistently with those paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100