LuaLS / LuaLS/lua-language-server

Improve Lua code to get current version

Open
#2,542 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

How are you using the lua-language-server?

NeoVim

Which OS are you using?

Other

What is the issue affecting?

Other

Expected Behaviour

I would like to get the current version for lua-language-server without changelog.md file.

Improve Lua code in script/version.lua to get current version (last Git tag).

Actual Behaviour

When a contributor packages lua-language-server for a distribution (Linux or BSD), the changelog.md file is not always included.

In script/version.lua file, the current version is defined (function loadVersion) with parsing of the changelog.md file. If this file is not present, the returned version is Unknown.

It will be better to get the current version without parsing of changelog.md file => get version from the last Git tag or define the current version in script/version.lua file.

Reproduction steps

N/A

Additional Notes

No response

Log File

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in script/version.lua at loadVersion and inspect how the current version is derived from changelog.md. Reproduce the packaging case with changelog.md absent, then verify the version comes from the last Git tag or an explicitly defined value instead of returning Unknown.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
devtools
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.