LuaLS / LuaLS/lua-language-server

Specific number params show up with comment color (in vscode)

Open
#2,275 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

Currently in vscode, this works:

---@param test 1
local function test(test)
end

test(1)

Where the only viable param for test is exactly 1. However there is a slight oddity where the specific number param sort of blends in with the comment.:

Screenshot_3 Screenshot_2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in VS Code with the Lua snippet from the report and compare the display of the numeric parameter with the surrounding comment. Trace the language-server or VS Code token-coloring path responsible for that parameter, and consider the issue done when the specific number is visually distinguishable from the comment while its parameter behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.