LuaLS / LuaLS/lua-language-server

Feature Request: Language server to be recursive regardless of trailing slashes

Open
#2,039 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
4.4k
Forks
442
PR merge metrics
No merged PRs in 30d

Description

When executing the language server binary with --check [path] flag, it will only diagnose the immediate child elements of the given path if it contains a trailing slash
Currently, if I want to diagnose a project different subdirectories via the CLI, e.g. the lua-language-server itself, I'll need a script that calls the binary for every subdirectory of the project to get a full report - and as a result I get a check.json for every subdirectory with diagnosed problems. Edit: Just have to make sure the path format is correct.

So for example, I'd like to call something like
.\language-server\bin\lua-language-server.exe --check .\language-server\ --recursive
and have all the source files in subdirectories checked as well.
That way it might also be possible to have a single check.json as a report as well.

The correct enhancement to propose is to handle things like a trailing slash in the path the same

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the language server's --check [path] entry point and trace how paths with trailing slashes are handled. Compare recursive diagnosis for equivalent paths, then verify that trailing-slash and non-trailing-slash inputs produce the same complete report.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.