LuaLS / LuaLS/lua-language-server

Unable to ignore applying only one library

未关闭
#1,696 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

enhancement
主要语言
Lua
星标
4.4k
派生
442
PR 合并指标
30 天内没有已合并 PR

描述

How are you using the lua-language-server?

Visual Studio Code Extension (sumneko.lua)

Which OS are you using?

Windows

What is the issue affecting?

Libraries

Expected Behaviour

When multiple libraries are detected, the user should be able to tell the server to stop asking to apply a specific library, and continue receiving suggestions for other libraries.

Actual Behaviour

Once the user selects “Don't show again”, workspace.checkThirdParty is set to false, preventing any suggestions from appearing.

Reproduction steps
  1. Enter the following in a file to trigger library detection:
    local assert = require("luassert")
    
    resty.a
    
    love.a
    
  2. When the “Apply library” popup appears, press “Don't show again”
  3. Try to automatically apply one of the other libraries automatically.
Additional Notes

A similar issue was resolved in v3.6.0 which allowed the server to continue recommending libraries when one was applied, but this issue is about when a user does not apply the suggested library.

Maybe it would make sense to create a new setting called workspace.libraryIgnore that is an array of ignored libraries. Then workspace.checkThirdParty can remain for backwards compatibility and so all suggestions can be disabled.

Log File

No response

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先跟踪 issue 中描述的 workspace.checkThirdParty 设置和“Don't show again”路径。在 Windows 上复现 luassert、resty 和 love 示例,然后验证拒绝一个库只会抑制该库,而其他库的建议仍然可用。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
devtools
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。