LuaLS / LuaLS/lua-language-server
feature: @since/@deprecated/@removed annotations for 3rd party libraries
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 4.4k
- Forks
- 442
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
I'd love it if we were able to use version markers for 3rd party libraries. OpenResty annotations would benefit from this.
annotation example
---@meta
local lib = {}
--- This function was added in lib 1.1.3
---
---@param a string
---@param b string
---@since 1.1.3
function lib.new(a, b) end
--- This function was added in lib 1.1.0 but has been deprecated since 2.0
---
---@param a string
---@param b string
---@since 1.1.0
---@deprecated 2.0
function lib.deprecated(a, b) end
--- This function was added in lib 1.1.0 but has been deprecated since 2.0 and removed in 3.0
---
---@param a string
---@param b string
---@since 1.1.0
---@deprecated 2.0
---@removed 3.0
function lib.removed(a, b) end
--- This function was added in lib 1.0
---
---@param a string
---@param b string
---@since 1.0
function lib.updated(a, b) end
--- ...and the signature was changed in lib 2.0 to add a 3rd param
---
---@param a string
---@param b string
---@param c string
---@since 2.0
function lib.updated(a, b, c) end
return lib
Initially, the language server could just add these things to the function's documentation.
Once this feature is in place, the next stage would be to make the language server aware of which version of $library is being used. Then, the language server could use this contextual info:
- provide type hints, docs, etc that are specific for the version being used (see
lib.updatedfrom my example) - provide diagnostics
- "warning:
lib.deprecatedhas been deprecated in version 2.0 (your version: 2.1)" - "error:
lib.removedwas removed in version 3.0 (your version: 4.7)"
- "warning:
discovering the library version
Here are some ideas I have:
explicitly-configured by the user
.luarc.json
{
"workspace": {
"library.version": {
"OpenResty": "1.2.3",
},
}
}
discoverable from meta/3rd/$lib/config.lua
top-level version declaration
version = function(workspace_dir)
-- do something to determine the version
return require("my_library").meta.version
end
using config actions
configs = {
{
key = 'Lua.workspace.library.version.OpenResty',
action = 'set',
value = (function()
return require("my_library").meta.version
end)(),
},
}
per-module annotation
by library author, from table key
-- lib.lua
---@version-from-field _VERSION
local lib = {
_VERSION = "1.2.3",
}
return lib
-- main.lua
local lib = require "lib" -- version is 1.2.3
by library author, from annotation
-- lib.lua
---@version 1.2.3
local lib = {}
return lib
-- main.lua
local lib = require "lib" -- version is 1.2.3
by library user
---@version 1.2.3
local lib = require "lib"
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Lies zuerst die Annotationsbeispiele und vergleiche dann die vorgeschlagene .luarc.json, meta/3rd/$lib/config.lua und die Versionsquellen der einzelnen Module. Das Issue nennt keine Implementierungsdateien oder Tests und beschreibt mehrere mögliche Phasen, daher sollte zunächst der Umfang für die Anzeige von @since, @deprecated und @removed in der Bibliotheksdokumentation abgestimmt werden. Als abgeschlossen sollte die Definition der Annotationssyntax und des Verhaltens der Versionsquellen enthalten sein.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- tooling
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 25/100