LuaLS / LuaLS/lua-language-server-rust

Version number is not semver compliant and crate version string is outdated

未关闭
#9 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Lua
星标
19
派生
6
PR 合并指标
30 天内没有已合并 PR

描述

Currently 3.13.2.2 is the most recent version tag of this git repository.

It would be ideal if version numbers were kept in compliance with semver and mirrored in Cargo.toml. Not only would that make it easier to find and figure out which version is in use, but it would also make the version number available at build-time in $CARGO_PKG_VERSION.

As the tags with an additional dot seems to only change files arguably not within the actual project sources, maybe they could be tagged as something similar to 3.13.2msgh2 in the future to indicate they only touch Microsoft GitHub Actions?

Had this been my project, I would likely have added a guard either at build-time or as a git-hook to ensure the different version strings were kept up to date with each-other.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先将当前的 git version tags 与 crates/luals/Cargo.toml 中的版本进行比较,并检查 Cargo 如何公开 CARGO_PKG_VERSION。确定预期的 semver 兼容 tag 和 crate-version policy,然后定义应如何防止不匹配。版本来源一致,并且所选的 guard 或 check 已记录且可验证,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
rust
领域
build-system, release
Issue 类型
重构
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
42/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。