LuaLS / LuaLS/lua-language-server-rust

Version number is not semver compliant and crate version string is outdated

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
19
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Currently 3.13.2.2 is the most recent version tag of this git repository.

It would be ideal if version numbers were kept in compliance with semver and mirrored in Cargo.toml. Not only would that make it easier to find and figure out which version is in use, but it would also make the version number available at build-time in $CARGO_PKG_VERSION.

As the tags with an additional dot seems to only change files arguably not within the actual project sources, maybe they could be tagged as something similar to 3.13.2msgh2 in the future to indicate they only touch Microsoft GitHub Actions?

Had this been my project, I would likely have added a guard either at build-time or as a git-hook to ensure the different version strings were kept up to date with each-other.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the current git version tags with the version in crates/luals/Cargo.toml and check how Cargo exposes CARGO_PKG_VERSION. Determine the intended semver-compatible tag and crate-version policy, then define how mismatches should be prevented. Done means the version sources are consistent and the chosen guard or check is documented and verifiable.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system, release
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.