LuaLS / LuaLS/lua-language-server-rust

Please make it possible to distinguish between implementations

未关闭
#7 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
Lua
星标
19
派生
6
PR 合并指标
30 天内没有已合并 PR

描述

Currently there is the main repository at https://github.com/LuaLS/lua-language-server and this rust rewrite. Both contain very similar language servers using identically named executables. While the long term plan might be for this one to either replace or get integrated into the other one, and thus there might be no desire for a name change, their colliding nature is problematic right now as they require being configured differently to be fully usable.

How about adding a way to query the executable of which implementation this is. One could imagine --version to output the information, but as it currently only outputs the numeric version that might be considered a breaking change. An alternative would be to add an additional --full-version flag including the name of the implementation, as done in pull request #8 accompanying this issue. That change also makes it possible to get a fuller version string using git rather than merely the approximate version parsed from the changelog. Additionally it adds a very rudimentary --help option which I'm not sure is correct. Please feel free to rewrite the commit for partial inclusion if desired.

In the quite likely event that the pull request is not possible to merge as is, minor suggested changes directly in it are welcome as well as keeping a supposedly more high level discussion in this issue.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先查看现有可执行文件的版本输出和 pull request #8,然后检查当前如何处理命令行选项。完成的标准是,用户可以通过 full-version 选项区分此实现,并且具有所提议的帮助行为,同时保留现有的数字版本输出。

由索引模型根据 Issue 内容生成。

评估

技术栈
git, lua, rust
领域
cli, devtools
Issue 类型
功能
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。