Layr-Labs / Layr-Labs/devkit-cli

Contract Development Workflow Issues and Missing Documentation

Offen
#217 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

Vorherrschende Sprache
Go
Sterne
27
Forks
10
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Summary

While developing custom contracts with DevKit, I've encountered several workflow issues and gaps in documentation that make contract development more difficult than it should be. These issues primarily relate to dependency management, build processes, and the lack of fast feedback loops for contract compilation.

Issues Identified

1. Missing Documentation for Adding Contract Dependencies

Problem: When developers need to install libraries or packages for custom contracts, there's no clear documentation on how to properly add dependencies.

Current Workaround Required:

  • For Forge-based dependencies:
    1. Navigate to .devkit/contracts/ and use forge install <dependency>
    2. Update remappings in .devkit/contracts/foundry.toml if needed
  • For Node.js-based dependencies:
    1. Create a package.json file in .devkit/contracts/
    2. Update remapping in .devkit/contracts/foundry.toml
    3. Manually modify the build command in .devkit/scripts/build to:
      cd .devkit/contracts && npm install && forge clean && forge build -- --include ../../contracts/**/*.sol >&2
      

Impact: This creates a poor developer experience and requires deep knowledge of the DevKit internals.

2. Build and Test Process Doesn't Include Custom Contracts Directory

Problem: Both the build and test targets in .devkit/contracts/Makefile only work with contracts within the .devkit/contracts/ directory and don't include the main ./contracts/ directory where custom contracts are placed.

build:
    forge clean
    forge build

test:
    forge test -vvv

While there is a deploy-custom-contracts target that references custom contracts, the basic build and test commands don't validate that custom contracts compile correctly or run tests for them.

Impact:

  • Developers may write custom contracts in ./contracts/ that have compilation errors, but these errors won't be caught until deployment time
  • Custom contract tests placed in ./contracts/test/ won't be executed by the standard test command
  • No way to run targeted tests for custom contracts during development
3. No Fast Contract Compilation Feedback Loop

Problem: There's no quick way to verify contract compilation without running the full devkit avs build command, which includes many time-consuming steps beyond contract compilation.

Current Limitations:

  • devkit avs build takes significant time due to multiple build steps (binaries, contracts, etc.)
  • Calling the build command in the Makefile directly doesn't build contracts outside the .devkit folder
  • No dedicated contract-only build command for rapid iteration

Impact: Slow feedback loops significantly impact development productivity when iterating on contract code.

Additional Context

These issues became apparent while following the standard DevKit workflow for custom contract development. The current process requires significant manual intervention and deep knowledge of the build system internals, which may deter developers from effectively using DevKit for contract development.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne mit der Prüfung von .devkit/contracts/Makefile, .devkit/scripts/build und .devkit/contracts/foundry.toml und vergleiche anschließend deren Targets mit dem Verzeichnis ./contracts/ und dem devkit avs build flow. Done sollte eine dokumentierte Einrichtung der Abhängigkeiten sowie einen praktikablen Build- und Testpfad umfassen, der benutzerdefinierte Contracts abdeckt und schnelleres Feedback bei der Kompilierung liefert.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
shell, solidity
Bereich
build-system, developer-experience, documentation, testing
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.