Lab-Lab-Lab / Lab-Lab-Lab/cpr-dev

DX: use a pre-commit hook to press commiters to ensure codestyle is consistent

Open
#49 0 comments 0 reactions 1 assignee View on GitHub

@JoshuaAHairston is already working on this.

Since Sep 6, 2024.

Dominant language
Shell
Stars
0
Forks
2
PR merge metrics
No merged PRs in 30d

Description

  1. do we really want a client-side pre-commit hook to enforce formatting? (maybe not because then we can't "save" our progress)
  2. definitely want something for when a PR is opened to either autoformat, or add a comment/error something that the requester should format their code before expecting the PR to be reviewed
  3. start by ensuring that the python black formatter is running for you in vscode, and figure out the commandline to make it run against all python files in the backend and open a pr to merge the formatted version

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.