Kong / Kong/httpsnippet

regression: CLI processing of globs

Open
#300 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
1.2k
Forks
242
PR merge metrics
No merged PRs in 30d

Description

The prior version of HTTPSnippet allowed processing of globs on the CLI as follows:

```shell
httpsnippet ./*.json --target node --client request --output ./snippets
```

```shell
$ tree snippets/
snippets/
├── endpoint-1.js
├── endpoint-2.js
└── endpoint-3.js
```

I wasn't aware of this prior functionality (and there were no tests covering it) so it was missed.

Shouldn't be too terrible to add back. Let's have some tests for it this time, too.

### Reproduction steps

run the following:
```shell
./bin/httpsnippet src/fixtures/requests/*.json --target node --client unirest --output ./example
```

And it returns this input:
```text
Unknown arguments: src/fixtures/requests/application-json.json, src/fixtures/requests/cookies.json, src/fixtures/requests/custom-method.json, src/fixtures/requests/full.json, src/fixtures/requests/headers.json, src/fixtures/requests/https.json, src/fixtures/requests/jsonObj-multiline.json, src/fixtures/requests/jsonObj-null-value.json, src/fixtures/requests/multipart-data.json, src/fixtures/requests/multipart-file.json, src/fixtures/requests/multipart-form-data.json, src/fixtures/requests/multipart-form-data-no-params.json, src/fixtures/requests/nested.json, src/fixtures/requests/query.json, src/fixtures/requests/short.json, src/fixtures/requests/text-plain.json
```

When it should, instead, process all of those files.

Contributor guide

Open the contributing guide

Research direction

Start with the CLI entry point at bin/httpsnippet and reproduce the failure using the glob command against src/fixtures/requests/*.json. Trace how arguments are parsed and how a single input is processed, then add CLI tests covering multiple globbed files and verify that each input produces an output instead of an unknown-arguments error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.