Generated multipart curl doesn't escape characters of form data fields
- Lingua principale
- TypeScript
- Stelle
- 1.2k
- Fork
- 242
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Related with https://github.com/Kong/insomnia/issues/3868
As of now we are not escaping double-quote characters that are in data fields of curl requests. This causes the curl request to fail.
Example generated curl:
```
curl --request GET \
--url http://mockbin.org/request/anything \
--header 'content-type: multipart/form-data; boundary=---011000010111000001101001' \
--form timestamp=2022-05-10T10:04:18.748Z \
--form field=test \
--form 'data=
TEST'
```
This doesn't seem to be the case for example for Python, where we escape characters we need to, and the request works fine:
```
import requests
url = "http://mockbin.org/request/anything"
payload = "-----011000010111000001101001\r\nContent-Disposition: form-data; name=\"timestamp\"\r\n\r\n2022-05-10T10:07:25.650Z\r\n-----011000010111000001101001\r\nContent-Disposition: form-data; name=\"field\"\r\n\r\ntest\r\n-----011000010111000001101001\r\nContent-Disposition: form-data; name=\"data\"\r\n\r\n\nTEST\r\n-----011000010111000001101001--\r\n"
headers = {'content-type': 'multipart/form-data; boundary=---011000010111000001101001'}
response = requests.request("GET", url, data=payload, headers=headers)
print(response.text)
```
Example postman generated curl:
```
curl --location --request POST 'https://test.com' \
--form 'timestamp="2021-07-14T01:02:34.567Z"' \
--form 'field="test"' \
--form 'data="
TEST"'
```
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start by locating the TypeScript code that generates multipart curl snippets and reproduce the shown XML field case. Update the generated form-data argument so embedded quote characters are escaped, then verify that the resulting curl request succeeds and add or update coverage if the repository has a relevant test.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- typescript
- Ambito
- tooling
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100