KnpLabs / KnpLabs/php-github-api

Why defaults don't match the github doc?

未关闭
#799 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
PHP
星标
2.2k
派生
587
PR 合并指标
30 天内没有已合并 PR

描述

For example current user api handler [link](https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/CurrentUser.php#L122) in `type` field has `owner` value as default but according github api we [link](https://developer.github.com/v3/repos/#list-your-repositories) have `all` as default.

P.S If necessary, I can fix it by PR.

Thanks for this awesome library.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start in lib/Github/Api/CurrentUser.php at the referenced line and compare the type field's default with the linked GitHub API documentation. Confirm the intended default and verify that the current-user repository request uses the documented value; done means the implementation and its behavior match the documentation.

由索引模型根据 Issue 内容生成。

评估

技术栈
php
领域
api
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
50/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。