KnpLabs / KnpLabs/php-github-api
Add ability to change default host
- Vorherrschende Sprache
- PHP
- Sterne
- 2.2k
- Forks
- 587
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
For the testing purposes I need to change `https://api.github.com` host to the mock API url, but there is no way to do it. All auto-tests should go to the mock service, instead of real GitHub.
We can use enterprise url as a workaround, but it looks like a wrong path.
I see 3 ways to implement this feature:
1. Check in `Github\Client::__construct` method if `AddHostPlugin` already defined, and skip it's definition in this case. Set enterprise URL will require the same check.
2. Add method to change host plugin manually in `Github\Client` object.
3. Make `Github\Client::getHttpClientBuilder` public.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start at Github\Client::__construct and Github\Client::getHttpClientBuilder, then inspect how AddHostPlugin and the enterprise URL are configured. Decide how callers can set a mock host without sending requests to real GitHub, and verify that the client’s requests use the configured host.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- php
- Bereich
- api
- Issue-Typ
- Feature
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100