KnpLabs / KnpLabs/php-github-api

Add ability to change default host

Open
#1,148 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.2k
Forks
587
PR merge metrics
No merged PRs in 30d

Description

For the testing purposes I need to change `https://api.github.com` host to the mock API url, but there is no way to do it. All auto-tests should go to the mock service, instead of real GitHub.

We can use enterprise url as a workaround, but it looks like a wrong path.

I see 3 ways to implement this feature:

1. Check in `Github\Client::__construct` method if `AddHostPlugin` already defined, and skip it's definition in this case. Set enterprise URL will require the same check.

2. Add method to change host plugin manually in `Github\Client` object.

3. Make `Github\Client::getHttpClientBuilder` public.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at Github\Client::__construct and Github\Client::getHttpClientBuilder, then inspect how AddHostPlugin and the enterprise URL are configured. Decide how callers can set a mock host without sending requests to real GitHub, and verify that the client’s requests use the configured host.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.