KnpLabs / KnpLabs/php-github-api

Allow specifying custom parameters

Open
#1,057 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
2.2k
Forks
587
PR merge metrics
No merged PRs in 30d

Description

The library locks you into providing only specific parameters. For example, `\Api\CurrentUser`:
![image](https://user-images.githubusercontent.com/54973868/158139424-d0b78a5b-861a-4d2a-b182-387ff02c3123.png)

The `/user/repos` endpoint has more parameters than just these, though, such as `per_page`, which is now being locked to 30 because users cannot specify a custom value.

If there *is* however a way to specify custom options without having to do any hacky things with `$client->getHttpClient`, I'd love to hear.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by examining Api\CurrentUser and how requests to /user/repos accept and pass parameters; the issue specifically mentions the client’s getHttpClient as a possible workaround. Determine how custom options such as per_page should be exposed, then verify that callers can override the current fixed value without relying on the underlying HTTP client.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.