KhronosGroup / KhronosGroup/dfdutils
Complete quoting for parameters of some CMake commands
- Vorherrschende Sprache
- C++
- Sterne
- 8
- Forks
- 9
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Some parameters (like “[`${CMAKE_CURRENT_SOURCE_DIR}/dfd2vk.inl`](https://github.com/KhronosGroup/dfdutils/blob/a80dd694522baf3afe52173addc3beebd80d1afb/CMakeLists.txt#L33-L52 "Update candidate")”) are passed to CMake commands in your build script without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.
I would recommend to apply [advices from the software documentation](https://cmake.org/cmake/help/v4.2/manual/cmake-language.7.html#lists "Description for CMake lists").
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start in CMakeLists.txt, especially the commands and parameters at lines 33-52, then read the linked CMake list documentation about quoting. Update the affected command arguments so variable values containing special characters remain safe, and verify that the project configures and builds successfully.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- cmake
- Bereich
- build-system
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 64/100