JuliaRandom / JuliaRandom/RandomNumbers.jl
Change name of supertype AbstractRNG?
- Langage dominant
- Julia
- Étoiles
- 100
- Forks
- 23
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
I think "re-using" the name `AbstractRNG` is not ideal:
`abstract type AbstractRNG{T<:Number} <: Base.Random.AbstractRNG end`
`AbstractRNG` is defined and exported by `Base` and `RandomNumbers`
```
using RandomNumbers
AbstractRNG
```
results in following:
```
WARNING: both RandomNumbers and Base export "AbstractRNG"; uses of it in module Main must be qualified
ERROR: UndefVarError: AbstractRNG not defined
```
Thus code that uses `AbstractRNG` without `RandomNumbers`, will no longer work when `using RandomNumbers`, without explicitly qualifying. i.e. that code will need modifying.
This can be problematic when one doesn't have access to the modules containing references to `AbstractRNG`.
Maybe this is some form of type piracy?
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.