JuliaPy / JuliaPy/PythonCall.jl

Why does the argument order of `pyconvert_add_rule` deviate from convention

Open
#363 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Julia
Stars
1.1k
Forks
86
Avg merge
1d 22h
Merged PRs (30d)
3

Description

According to the [Julia Docs](https://docs.julialang.org/en/v1/manual/style-guide/#Write-functions-with-argument-ordering-similar-to-Julia-Base), function arguments should be placed first because "Putting a function argument first permits the use of [do](https://docs.julialang.org/en/v1/base/base/#do) blocks for passing multiline anonymous functions."

Is there a reason for not following this convention?
Would it be reasonable to support the conventional argument order in addition to the current argument order?
Can we switch fully to the conventional argument order and deprecate the current argument order / remove it in the next breaking release?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the pyconvert_add_rule definition and its current callers. Review the Julia argument-ordering convention and determine which argument order should be supported, including the compatibility and deprecation decision; done means the API direction is agreed and documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia, python
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.