JetBrains / JetBrains/CMake-Tutorial-sample

assertEquals from assert_macro.h actually is assertTrue

Open
#2 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
40
Forks
13
PR merge metrics
No merged PRs in 30d

Description

assertEquals would need two have two parameters, not just one.

// misnomer:
assertEquals( (0+0) == 0 )
// should be:
assertTrue( (0+0) == 0 )

// assertEquals I would expect to call
// providing both the expected value and the actual value:
assertEquals( 0, (0+0) )

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with assert_macro.h and search for assertEquals usages in the sample project. Check whether the macro is intended to represent a one-argument boolean assertion or a two-argument equality assertion, then inspect any affected examples or tests. Done means the assertion names and parameter behavior match their documented meanings.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.