JessYanCoding / JessYanCoding/ProgressManager

Progress Listener can't listen to url with "/" query

Open
#67 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
2.7k
Forks
289
PR merge metrics
No merged PRs in 30d

Description

### Problem

Progress Listener cannot listen to request with query that contains "/", because mResponseListeners Hashmap failed to detect item, when requested "/" change into "%2F", so containsKey(key) will return false

ex.

```kotlin
https://localhost/v3.1?type_file=pdf&start_date=2022/01/07&end_date=2022/02/06
```

the start_date and end_date will cause Problem.

#### Already Done

I've already tried to replace "/" before request with "%2F" but it reversed now in the HashMap key it has "/" but the checked key contains "%2F", so it still return false.

#### Potential Problem

Please check on ProgressManager.java on line 259

#### Potential Fix

Implement more complex search algorithm for checking key, or custom check on HashMap key.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.