JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources
Polymorphic has_many relationships linkage data skips authorization checks added to records_for
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Ruby
- Sterne
- 2.3k
- Forks
- 546
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
I'm using a simple method of authorization which is being broken by link objects for polymorphic has many relationships.
I have a ResourceBase class derived from JSONAPI::Resource, which overrides records and records_for to only return authorized records. This was working fine until I added a polymorphic has many relationship to one of my resources. At which point a number of unauthorized link objects were appearing for the resource's polymorphic relationship.
The reason for this being that JSONAPI::ResourceSerializer#foreign_key_types_and_values makes a call directly to the resources underlying model for polymorphic relationships. This call skips the records_for call in which I have been performing my authorization.
foreign_key_types_and_values is the only place in which ResourceSerializer accesses the resource's underlying model leading me to believe that there should be a method on the JSONAPI::Resource which ResourceSerializer should be calling in this case.
A possible solution would be to:
- Change
foreign_key_types_and_valuesto call a method onResourceto retrieve the foreign keys and types, for both polymorphic and non-polymorphic relationships. - Change
Resource::_add_relationshipto create a new method on the resource for each polymorphic has many relationship. This method would return both the type and id of the related models making sure to do so by callingrecords_for.
I'll see if I can put together a PR for this, but thought I'd mention the bug and my suggested fix first.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit JSONAPI::ResourceSerializer#foreign_key_types_and_values und Resource::_add_relationship und verfolge anschließend, wie records_for für autorisierte Beziehungsdatensätze verwendet wird. Verifiziere, dass polymorphe has_many-Verknüpfungsdaten dem Autorisierungspfad auf Ressourcenebene folgen und dass nicht autorisierte verknüpfte Datensätze keine Link-Objekte mehr erzeugen.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- ruby
- Bereich
- api, authorization, backend
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100