JSONAPI-Resources / JSONAPI-Resources/jsonapi-resources

BUG: posting a bad id to a has_may raises a 500. Should raise a 4xx

Aperta
#1,388 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Ruby
Stelle
2.3k
Fork
546
Nessuna PR unita negli ultimi 30g

Descrizione

This issue is a (choose one):

  • Problem/bug report.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

Running

  • jsonapi-resources 0.9.12 (can't yet upgrade to 0.10 due to how POST to poro resources changed :(
  • rails 6.1.5.1
  • cruby 3.0.3

Given a POST to /v1/tickets/2460688

with body

"relationships": {"file-attachments": {"data": [{"type": "file-attachments", "id": "292356"}] }

for a resource with fields defined as

    has_many :file_attachments, always_include_linkage_data: true

JR raises a 500

ActiveRecord::RecordNotFound
Couldn't find FileAttachment with 'id'=[292356]

but I think it should return a 400

I'm happy to work on a PR or failing test if we can define the behavior and where it should be

stacktrace 
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:85:in `block in replace_to_many_links'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:55:in `block in change'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:54:in `change'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:84:in `replace_to_many_links'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:424:in `block in _replace_fields'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:423:in `each'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:423:in `_replace_fields'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:115:in `block in replace_fields'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:61:in `block (2 levels) in change'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:60:in `block in change'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:106:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:58:in `change'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/resource.rb:114:in `replace_fields'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/processor.rb:252:in `replace_fields'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/processor.rb:58:in `block (2 levels) in process'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/processor.rb:57:in `block in process'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/processor.rb:56:in `process'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation.rb:16:in `process'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:58:in `block in process_operation'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:63:in `with_default_handling'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:57:in `process_operation'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:29:in `block (2 levels) in process'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:28:in `each'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:28:in `block in process'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:43:in `block in transaction'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:93:in `block (2 levels) in transaction'",
.bundle/vendor/ruby/3.0.0/gems/activerecord-6.1.5.1/lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `block in transaction'",
.bundle/vendor/ruby/3.0.0/gems/activerecord-6.1.5.1/lib/active_record/connection_adapters/abstract/transaction.rb:319:in `block in within_new_transaction'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/concurrency/load_interlock_aware_monitor.rb:26:in `block (2 levels) in synchronize'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `handle_interrupt'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/concurrency/load_interlock_aware_monitor.rb:25:in `block in synchronize'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `handle_interrupt'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/concurrency/load_interlock_aware_monitor.rb:21:in `synchronize'",
.bundle/vendor/ruby/3.0.0/gems/activerecord-6.1.5.1/lib/active_record/connection_adapters/abstract/transaction.rb:317:in `within_new_transaction'",
.bundle/vendor/ruby/3.0.0/gems/activerecord-6.1.5.1/lib/active_record/connection_adapters/abstract/database_statements.rb:320:in `transaction'",
.bundle/vendor/ruby/3.0.0/gems/activerecord-6.1.5.1/lib/active_record/transactions.rb:209:in `transaction'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:92:in `block in transaction'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:42:in `transaction'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/operation_dispatcher.rb:24:in `process'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:86:in `block in process_operations'",
.bundle/vendor/ruby/3.0.0/gems/activesupport-6.1.5.1/lib/active_support/callbacks.rb:98:in `run_callbacks'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:85:in `process_operations'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:77:in `process_request'",
.bundle/vendor/ruby/3.0.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/acts_as_resource_controller.rb:44:in `update'",
.bundle/vendor/ruby/3.0.0/gems/actionpack-6.1.5.1/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'",
Bug reports:

related

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da lib/jsonapi/resource.rb, in replace_to_many_links, seguendo lo stack trace attraverso lib/jsonapi/processor.rb e lib/jsonapi/operation_dispatcher.rb. Riproduci il POST con un id di allegato file inesistente e analizza la gestione degli errori esistente, quindi aggiungi un test di regressione che copra la risposta 4xx prevista e il payload di errore.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
rails, ruby
Ambito
api, backend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.